Add simulated hardware #69
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
src/blop/agent.py
Outdated
| dets: Sequence[Signal] = [], | ||
| detectors: Sequence[Signal] = [], |
There was a problem hiding this comment.
Let's use immutable defaults, e.g., None and assign a list later in the __init__ method.
src/blop/agent.py
Outdated
| x = self.dofs(active=True).transform(x) | ||
| # x = self.dofs(active=True).transform(x) |
There was a problem hiding this comment.
Let's remove it and have a docsting explaining x does not need to be normalized.
src/blop/sim/beamline.py
Outdated
| for item in items: | ||
| yield item |
There was a problem hiding this comment.
Based on linter recommendation for https://github.com/NSLS-II-HEX/hextools/blob/870b1c928746501ca2f8f4404c49d895986c4e2f/src/hextools/germ/ophyd.py#L124:
| for item in items: | |
| yield item | |
| yield from items |
| class HDF5Handler(HandlerBase): | ||
| specs = {"HDF5"} | ||
|
|
||
| def __init__(self, filename): | ||
| self._name = filename | ||
|
|
||
| def __call__(self, frame): | ||
| with h5py.File(self._name, "r") as f: | ||
| entry = f["/entry/image"] | ||
| return entry[frame] |
There was a problem hiding this comment.
Let's create an issue to make it compatible with databroker v2.
| from . import functions # noqa | ||
|
|
||
|
|
||
| def get_beam_stats(image, threshold=0.5): |
There was a problem hiding this comment.
This function has a duplicate in src/blop/digestion/__init__.py. Let's leave just one of them.
Inspired by conversations with some beamline scientists, it would help to have more concrete optimization problems. This adds a lightweight simulation of a beamline mimicking a KB mirror endstation. We may add more examples in the future.